QueryManager - Prevent queries leaking between check instances #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
|
FlorianVeaux
force-pushed
the
florian/fix_qm_state2
branch
from
c039855
to
91aa761
Compare
FlorianVeaux
force-pushed
the
florian/fix_qm_state2
branch
from
91aa761
to
33f3b43
Compare
|
Is this different than: #7739 |
Different implementation to choose from indeed. This one requires modification to every single integration but is a bit cleaner. The other one doesn't require changes to integrations but is a bit more hacky. |
coignetp
reviewed
Oct 9, 2020
|
It would, but no extras or marketplace integration is currently using that |
coignetp
previously approved these changes
Oct 9, 2020
FlorianVeaux
force-pushed
the
florian/fix_qm_state2
branch
from
0d3def2
to
6667ef7
Compare
|
Much nicer indeed |
ofek
approved these changes
Oct 9, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2020
* QueryManager - Prevent queries leaking between check instances * Fix snowflake c9c2151
This was referenced Nov 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database checks pass instances of 'Query' directly to the QueryManager for them to be 'compiled' and used.
The QueryManager modifies those 'Query' instances in-place which means that multiple instances of a same check will share the same references to those 'Query' objects.
It wouldn't be a problem if those Query did not contain references to bounded methods of the check.
Impact:
Any check currently using the QueryManager with multiple configuration instances will see metrics that should be submitted with one instance being submitted with another one. This is transparent to users, metrics will be sent to Datadog app anyway.
If the check is using autodiscovery, configuration instances are generated dynamically. Instances can be unscheduled and that leads to integrations trying to report metrics through another un-existing check instance which the agent refuses to send.