Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report io thread metrics #9018

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

jlisam
Copy link
Contributor

@jlisam jlisam commented Mar 24, 2021

What does this PR do?

Since Redis 6 brings support for multi threaded IO, this PR adds support to redisdb to retrieve io_threads_active, io_threaded_writes_processed io_threaded_reads_processed from info and store them as metrics. These metrics will help determine the rate of I/O threads usage.

Motivation

We will be supporting Redis 6 in the near future and will need the new metrics piped to Datadog for evaluation and monitoring.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@jlisam jlisam requested a review from a team as a code owner March 24, 2021 01:41
@jlisam jlisam force-pushed the support-redis-6-io-threads-metrics branch from d0b4a84 to c9207b7 Compare March 24, 2021 17:37
redisdb/metadata.csv Outdated Show resolved Hide resolved
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
@hithwen hithwen merged commit 74d3639 into DataDog:master Apr 14, 2021
@jlisam jlisam deleted the support-redis-6-io-threads-metrics branch April 28, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants