Add support for Airflow 2 #9064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
coignetp
force-pushed
the
paul/airflow-2
branch
from
83ebfd4
to
e71f608
Compare
| @@ -26,10 +26,44 @@ def test_service_checks_cannot_connect(aggregator): | |||
| 'json_resp, expected_healthy_status, expected_healthy_value', | |||
| [({'status': 'OK'}, AgentCheck.OK, 1), ({'status': 'KO'}, AgentCheck.CRITICAL, 0), ({}, AgentCheck.CRITICAL, 0)], | |||
| ) | |||
| def test_service_checks_healthy(aggregator, json_resp, expected_healthy_status, expected_healthy_value): | |||
| def test_service_checks_healthy_exp(aggregator, json_resp, expected_healthy_status, expected_healthy_value): | |||
There was a problem hiding this comment.
How come this gets tested for our v2 environment?
There was a problem hiding this comment.
This is a unit test, so it's just testing the behaviour, not against the environment
luisgonzalex
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Airflow 2.0+ has a stable API, and is deprecating
/api/experimental. https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.htmlThis PR check the stable endpoints first.
Motivation
Additional Notes
The stable endpoint is more detailed https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#tag/Monitoring
These details are added in the service check message.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached