-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: Change port name delimiter from _ to | #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I hope thats everything |
If you look at #193 we wanted to use a pipe as delimiter |
I don't quite understand your regex changes. You put |
You do want flow names to be allowed to have "_" in them, right? |
You mean | should only be allowed between flow names, right? |
Yes. But you do want "_" to be allowed in a single flow name and also in labels to be compatible with MicroSecEnd? That's why I didn't remove it from the Regex |
Yes id like that |
Alright, it should be ready to merge then. |
I will test the regex some more tomorrow then merge if i don't find an edgecase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adopt the two comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.