-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new files for MCPL #658
new files for MCPL #658
Conversation
/reviewpad run |
/reviewpad summarize |
AI-Generated Summary: This pull request introduces changes in the test files and MCPL converter. The main modifications include:
Overall, the update focuses on configuring pre-commit hooks and ensuring the test files are using protons instead of neutrons as the particle. |
AI-Generated Summary: This pull request introduces several changes to the codebase:
|
AI-Generated Summary: This pull request includes various updates to the codebase involving type hints, tests, binary files, requirements, pre-commit hooks, and particle data files. Key updates revolve around improving testing of phasespace BDO files, checking their properties, reading their content, generating MCPL files from them, and updating SHIELD-HIT12A particle data. Additional changes involve adding new dependencies and pre-commit hooks, modifying binary files, and improving file organization. |
AI-Generated Summary: This pull request includes updates to multiple files, adding new dependencies, binary files, test data, and configuration settings. Key changes include the update of |
AI-Generated Summary: This pull request introduces various changes across multiple files, including adding new binary and text files for test results in the In Tests for MCPL converter have been updated, and additional tests have been added for BDO file generation and concatenation. Logging facilities have been improved in the test suite. In the Finally, a new |
AI-Generated Summary: This pull request introduces various updates and additions across multiple files. Key changes include adding import statements for Additionally, this PR adds new binary files in the Finally, several updates have been made to the |
AI-Generated Summary: This pull request includes various changes to improve code quality, maintain a consistent code style, enhance error handling, and extend functionality. Key modifications include updating particle data in test files, adding pre-commit hooks, refactoring test cases using pytest fixtures and assertions, improving typing and error handling, updating dependencies, and adding new test files containing simulated data. Additionally, new pytest fixtures and utility functions have been added for downloading and installing the demo version of SHIELD-HIT12A. |
AI-Generated Summary: This pull request includes several updates to the test framework, such as the addition of new test files, fixtures, utility functions, and test cases, as well as modifications to existing test files. The main focus is on the testing of different aspects of MCPL file conversion and validation, binary file handling, SHIELD-HIT12A demo version setup, and input file generation. New test functions have been introduced to validate specific cards within the generated input files, verify exit codes and file formats, and test the ability to concatenate multiple BDO files. A new .pre-commit-config.yaml file has been added for pre-commit hooks and updates were made to the test requirements file. The |
AI-Generated Summary: This pull request includes several updates to files, including adding new binary files in 'tests/res/shieldhit/phasespace' directory, modifying '.gitignore', removing the binary file 'tests/res/shieldhit/executable/shieldhit', updating test configuration and requirement files, and introducing new test files. Furthermore, changes have been made to improve logging, error handling, and concatenation feature support in various files. Test functions have been refactored from a unittest class structure into individual pytest functions for better readability and modularity. The pull request also adds several pre-commit hooks to the project, addressing code formatting and file management issues. Finally, new tests for BDO files and MCPL conversion have been added, improving overall test coverage. |
AI-Generated Summary: This pull request includes changes to several test files, refactoring and improving test implementations, and additional files and fixtures related to SHIELD-HIT12A, such as new BDO files and MCPL simulation results. It adds type hinting and error handling in the input_output.py script, as well as configuration updates to the pytest.ini file and the addition of pre-commit hooks for code formatting and quality checks. The pull request also contains changes to the .gitignore file, removal of obsolete binary files, and improvements in logging and the running variance algorithm. Additionally, new test functions and fixtures are introduced for checking file types and file conversion. Overall, these changes enhance the project's functionality, test coverage, and code quality. |
AI-Generated Summary: This pull request introduces various changes to the project's files, including:
Overall, the pull request contains numerous improvements to the codebase, such as enhanced readability, maintainability, and test coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works.
I've fixed the PDG codes in the
51-phsp-export
branch of SHIELD-HIT12A source code. This change needs to be reflected in the testing files for pymchelper. Previously allmost all the particles were neutrons, while we expected protons.This PR includes as well solid refactoring of tests suite (moving from unittest to pytest framework).
Concatenation for the MCPL data object was also implemented, which should enable dealing with concatenating large files using
convertmc --many *.bdo