Merge develop to main for 1.0.4 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oy-file and distributionManagement sections. 2. Bump the version to 1.0.4
taojing2002
changed the title
mbjones
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
@taojing2002 This looks fine. The only thing you seemed to do is to back out the changes to ${project.url}, so now the WARNING in the build about the use of deprecated features is back. See code below. It probably doesn't matter at this point, but in general I think its best to not use deprecated features, which promotes longevity. I truly don't understand why one works and the other does not, as it seems irrelevant to your build result. But let's not dwell on this given that you have it working.
$ mvn test
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.dataone:speedbagit:jar:1.0.4
[WARNING] The expression ${url} is deprecated. Please use ${project.url} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
|
Thank you, Matt. Yeah, it is an issue and we need to figure it out in the
next release.
…On Sat, Mar 25, 2023 at 10:39 PM Matt Jones ***@***.***> wrote:
***@***.**** approved this pull request.
@taojing2002 <https://github.com/taojing2002> This looks fine. The only
thing you seemed to do is to back out the changes to ${project.url}, so
now the WARNING in the build about the use of deprecated features is back.
See code below. It probably doesn't matter at this point, but in general I
think its best to not use deprecated features, which promotes longevity. I
truly don't understand why one works and the other does not, as it seems
irrelevant to your build result. But let's not dwell on this given that you
have it working.
$ mvn test
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.dataone:speedbagit:jar:1.0.4
[WARNING] The expression ${url} is deprecated. Please use ${project.url} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
—
Reply to this email directly, view it on GitHub
<#29 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5QQDHM2JOW26NVRYZFMRTW57JAFANCNFSM6AAAAAAWGBMX3U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I searched the code base and compared the commit history, and found the only place to hold the version number is pom.xml. So I think the change of pom.xml is good enough for this release, which just fixed the issue on the deploy process.