Reprocessing extension without session activations inside #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed getting Session from SessionScope - Added support for giving external session to reprocessing action execution - Changed tests in order to be up-to-date - Added Session.IsDisposed to be able to check external sessions
AlexUstinov
previously approved these changes
Apr 21, 2021
| @@ -37,14 +33,33 @@ public IExecuteConfiguration WithTransactionOpenMode(TransactionOpenMode transac | |||
| return this; | |||
| } | |||
|
|
|||
| public IExecuteConfiguration WithExternalSession(Session session) | |||
There was a problem hiding this comment.
What do you think about renaming this to just WithSession ?
There was a problem hiding this comment.
Well, I wanted the name to be as clear as possible. That's why I named it .WithExternalSession(). I believe we can rename WithXXX methods but in ExecutionContext I'd prefer the name which underlines nature of the instance, maybe keep ExternalSession or replace it with UserSession (because we don't open it) or something.
- removed commented code - used ordinal comparison for strings - some formatting applied
AlexUstinov
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #126
Breaking changes.
Makes reprocessing not use
SessionScopeinside (it does not get session out of it and does not open any activation scopes). To compensate that I provided a way to pass aSessioninstance from outside by usingDomainExtensions.WithExternalSession(this Domain, Session)extension orIExecutionConfiguration.WithExternalSession(this Domain, Session)