Constant Type identifiers as parameter of SQL query #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only firebird does not support parameter as selected column so it was excluded from it.
TypeId functionality is such a basic thing so almost whole test project tests it
These are used when cast one persistent type to another
AlexUstinov
reviewed
Jun 26, 2021
Orm/Xtensive.Orm.Firebird/Sql.Drivers.Firebird/v2_5/ServerInfoProvider.cs
Outdated
Show resolved
Hide resolved
Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/SqlCompiler.cs
Outdated
Show resolved
Hide resolved
...Xtensive.Orm.Tests/Storage/CommandProcessing/BatchingCommandProcessorParametersManagement.cs
Outdated
Show resolved
Hide resolved
Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/SqlCompiler.cs
Outdated
Show resolved
Hide resolved
...Xtensive.Orm.Tests/Storage/CommandProcessing/BatchingCommandProcessorParametersManagement.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.Index.cs
Optimize TypeId accessors
# Conflicts: # Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v8_0/Compiler.cs # Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.cs # Orm/Xtensive.Orm/Sql/Compiler/SqlCompiler.cs # Orm/Xtensive.Orm/Sql/Info/QueryFeatures.cs
no support for parameter as column in SQL query
# Conflicts: # Orm/Xtensive.Orm/Orm/Configuration/DomainConfiguration.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some queries had type identifiers as constant columns in SELECT queries. The PR replace them with parameters.
Almost all supported providers support it except for Firebird 2.5, it remains using constants due to inability to have parameter as column in selected columns.