Improve TimeSpan.TotalMilliseconds extraction and .Milliseconds extraction for types which has this part #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-kulakov
commented
Mar 4, 2025
alex-kulakov
commented
- From PostgreSQL 9.0 there is more efficient and faster way to get total milliseconds of native interval, rather than general approach based on sum of each part - using extraction of 'epoch' part of interval
- Improved Date/DateTime/DateTimeOffset/TimeSpan .Milliseconds extraction, it lacked trunc operation for milliseconds as well as for seconds (which existed). Now this trunc operation added and results are correct
… int8 otherwise milliseconds part of 59.999999 seconds became 0
Based on epoch extraction, it is less complicated than sum of several parts expecially when base expression is complicated so it required many copies of base expression. New approach is also lest costy.
Trunc operation added to correctly return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.