Tests infrastructure improvements - domain types registration with cache #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added alphabetical index for namespaces to not search position from start all the time - fixed issue of namespaces with one type - added extra measure to not allow forever-loops
- Apply alphabetical index over biggest subnamespaces "Issues" and "Upgrade" - small optimizations - majority of models are less than 6 items so window is decreaded, it will affect big models of 100s types but it is already faster - registration extension moved to TestHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not get all types of assembly on every registration of types from a namespace created cache of types per assembly. Additionally, to not enumerate through 5000+ types in every test that require domain, alphabetic index of namespaces added. Together with new search algorithm, based on order of types in Assembly.GetTypes() result array, this allows to search for needed part of assembly types faster and efficiently, saving not only on iterations but on garbage collections (no 6000+ arrays of 5000+ elements that lived only for several types needed)