Skip to content

Remove unused options from StringFormatter #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2017
Merged

Remove unused options from StringFormatter #72

merged 1 commit into from
Sep 28, 2017

Conversation

thiemowmde
Copy link
Contributor

No description provided.

@thiemowmde thiemowmde added this to the 1.0.0 milestone Sep 1, 2017
@JeroenDeDauw
Copy link
Member

Not sure if breaking change - does the behavior really change? In PHP you can pass a non-existing parameter. Not sure about all the various strict modes and whatnot.

@thiemowmde
Copy link
Contributor Author

All PHP versions must allow to pass additional parameters to functions because there is no way to know if some later code calls func_get_args. (Not 100% sure about strict mode.) That's why this is indeed not a (technical) breaking change. The $options parameter got ignored before and after the change.

However, I think this should still count as a (semantical) breaking change.

@JeroenDeDauw JeroenDeDauw merged commit 3d831c7 into master Sep 28, 2017
@JeroenDeDauw JeroenDeDauw deleted the stringOptions branch September 28, 2017 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thiemowmde @JeroenDeDauw