Skip to content

Conversation

thiemowmde
Copy link
Contributor

Just create an instance instead of using PHP's dark magic to turn a string into an object. This makes it much easier for tools to find usages, for example.

Similar to DataValues/Common#23, which is for parser tests. This patch is for formatter tests.

Note that this is not the final patch. I want to actually remove the method and make getInstance abstract (done in #10) before creating a release.

Bug: T92268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants