Deprecate getFormatterClass in favor of getInstance #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just create an instance instead of using PHP's dark magic to turn a string into an object. This makes it much easier for tools to find usages, for example.
Similar to DataValues/Common#23, which is for parser tests. This patch is for formatter tests.
Note that this is not the final patch. I want to actually remove the method and make
getInstance
abstract (done in #10) before creating a release.Bug: T92268