Remove unused code from DataValueSerializer #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
thiemowmde
force-pushed
the
arrayTypeHint
branch
from
4ef3e4f to
ea30f71
Compare
thiemowmde
force-pushed
the
arrayTypeHint
branch
from
ea30f71 to
eed586e
Compare
|
Not worth the hassle of a major release, we can look for such changes if we ever get reason to make such a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change because there may be a subclass overriding the protected method that is now removed. However, I assume this method was never intended to be part of the interface of this class.