Skip to content

Conversation

fvazquez-caylent
Copy link
Contributor

To allow for further tightening of IAM permissions, the RDS module should allow users to set tags that will be applied to the RDS postrgre database and every resource created because of this module.

Summary of changes:

Add new variable tags.
Propagate the tags to untagged resources.
Add deprecation notice for additional_tags, update descriptions to keep consistency across modules.
Create Examples/Minimal with exampled tags.

@fvazquez-caylent fvazquez-caylent requested a review from a team as a code owner July 14, 2021 16:52
@tamr-teamcity
Copy link
Collaborator

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

3 similar comments
@tamr-teamcity
Copy link
Collaborator

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

@tamr-teamcity
Copy link
Collaborator

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

@tamr-teamcity
Copy link
Collaborator

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

@alexis-caylent alexis-caylent changed the title Ca 10 tag based authorization CA-10 Tag based authorization Jul 21, 2021
Copy link
Contributor

@souza-dan souza-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fvazquez-caylent fvazquez-caylent force-pushed the CA-10-Tag-based-authorization branch from f0d5072 to 18e9bd9 Compare July 21, 2021 19:11
@fvazquez-caylent fvazquez-caylent requested a review from a team as a code owner July 21, 2021 19:11
@fvazquez-caylent fvazquez-caylent merged commit 15d3de7 into Datatamer:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants