New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plane defaults #467

Merged

m-reuter merged 3 commits into Deep-MI:dev from agirodi:development/plane_defaults

Mar 14, 2024

Contributor

agirodi commented Feb 29, 2024 •

edited

Loading

This PR adds:

Backup URL feature, where the checkpoint download can have multiple URLs, in case the first one is unreachable or similar
New yaml files (CerebNet/config/checkpoint_paths.yaml and FastSurferCNN/config/checkpoint_paths.yaml) for default values for the configuration path, the checkpoint path as well as the URLs

dkuegler reviewed

View reviewed changes

plane_default.yaml Outdated Show resolved Hide resolved

dkuegler reviewed

View reviewed changes

plane_default.yaml Outdated Show resolved Hide resolved

dkuegler reviewed

View reviewed changes

plane_default.yaml Outdated Show resolved Hide resolved

dkuegler reviewed

View reviewed changes

FastSurferCNN/README.md Outdated Show resolved Hide resolved

dkuegler reviewed

View reviewed changes

Member

dkuegler left a comment

I would like this to be done a bit differently.

CerebNet/run_prediction.py Outdated Show resolved Hide resolved

CerebNet/run_prediction.py Outdated Show resolved Hide resolved

FastSurferCNN/utils/parser_defaults.py Outdated Show resolved Hide resolved

CerebNet/run_prediction.py Outdated Show resolved Hide resolved

CerebNet/run_prediction.py Show resolved Hide resolved

CerebNet/run_prediction.py Outdated Show resolved Hide resolved

agirodi force-pushed the development/plane_defaults branch from 4a9f870 to c5ebea7 Compare

March 12, 2024 13:46

agirodi requested a review from dkuegler

March 12, 2024 13:48

dkuegler requested changes

View reviewed changes

Member

dkuegler left a comment

Please check if the changed I made break anything. Otherwise can be merged.

FastSurferCNN/run_prediction.py Outdated Show resolved Hide resolved

FastSurferCNN/run_prediction.py Outdated Show resolved Hide resolved

FastSurferCNN/utils/checkpoint.py Outdated Show resolved Hide resolved

FastSurferCNN/utils/checkpoint.py Show resolved Hide resolved

FastSurferCNN/utils/checkpoint.py Outdated Show resolved Hide resolved

FastSurferCNN/utils/checkpoint.py Outdated Show resolved Hide resolved

FastSurferCNN/utils/checkpoint.py Outdated Show resolved Hide resolved

agirodi requested a review from dkuegler

March 14, 2024 10:39

dkuegler approved these changes

View reviewed changes

agirodi and others added 3 commits

March 14, 2024 13:02


          add plane defaults

a37f8b8

Edit typing
Remove old/hard-coded urls and file names
Co-authored-by: David Kügler <david.kuegler@dzne.de>


          Apply suggestions from code review

1d3468d


          fix missing import

77a67da

dkuegler force-pushed the development/plane_defaults branch from 788a9c1 to 77a67da Compare

March 14, 2024 12:02

m-reuter merged commit b0a903c into Deep-MI:dev

dkuegler mentioned this pull request

Sphinx workflow #475

Merged

dkuegler mentioned this pull request

Model download issue #518

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet