Skip to content

Conversation

IanMayo
Copy link
Contributor

@IanMayo IanMayo commented Aug 7, 2025

Summary

  • Fixed keyboard arrow key controls for harmonic sets in analysis and doppler modes
  • Replaced mode-dependent harmonic updates with direct state management in keyboard control system
  • Maintained clean architecture by avoiding harmonic-specific methods in BaseMode class

Technical Changes

  • Modified moveSelectedHarmonicSet() in keyboardControl.js to handle harmonic updates directly
  • Replaced instance.currentMode.updateHarmonicSet() calls with inline state management
  • Added proper UI updates and state listener notifications for cross-mode consistency

Issue Resolution

Resolves #118 - keyboard commands now work for harmonics when selected in any mode (analysis, doppler, harmonics), not just harmonics mode.

Test Plan

  • All existing tests pass (59/59)
  • TypeScript compilation successful
  • Build process completes without errors
  • Keyboard controls work for harmonics in all modes
  • No regression in existing harmonic functionality

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for gramframe ready!

Name Link
🔨 Latest commit 387ed23
🔍 Latest deploy log https://app.netlify.com/projects/gramframe/deploys/689463aa3edfa80008f3b72c
😎 Deploy Preview https://deploy-preview-120--gramframe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IanMayo IanMayo merged commit b7928c6 into main Aug 7, 2025
4 checks passed
@IanMayo IanMayo deleted the 118-keyboard-harmonics branch August 7, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use keyboard commands to adjust harmonic, when not in harmonic mode
1 participant