refactor: simplify state structure by removing AxesConfig wrapper #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gramframe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the state structure by removing the unnecessary AxesConfig wrapper type that only contained a single margins property, making the codebase more direct and readable.
- Removes
AxesConfigtypedef and updatesGramFrameStateto useAxesMarginsdirectly - Changes all references from
state.axes.marginstostate.marginsthroughout the codebase - Updates state initialization to remove the
axeswrapper object
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.js | Removes AxesConfig typedef and updates GramFrameState type definition |
| src/core/state.js | Updates initial state structure to use margins directly instead of nested axes.margins |
| src/rendering/cursors.js | Updates margin access in cursor drawing functions |
| src/modes/pan/PanMode.js | Updates margin access in pan mode calculations |
| src/modes/harmonics/HarmonicsMode.js | Updates margin access in harmonic line calculations |
| src/modes/doppler/DopplerMode.js | Updates margin access in Doppler mode rendering |
| src/modes/BaseMode.js | Updates margin access in viewport configuration |
| src/core/keyboardControl.js | Updates margin access in keyboard movement functions (3 occurrences) |
| src/core/events.js | Updates margin access in coordinate conversion |
| src/components/table.js | Updates margin access in layout and rendering functions (4 occurrences) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the state structure by removing the unnecessary
AxesConfigwrapper type that only contained a singlemarginsproperty.Changes
✅ Type Simplification
AxesConfigtypedef (was only wrappingmargins)GramFrameStateto useAxesMarginsdirectlyViewportConfigto referencemarginsdirectly✅ Code Updates
state.axes.margins→state.marginsthroughout codebase (14 occurrences)src/core/state.jssrc/modes/BaseMode.jssrc/modes/doppler/DopplerMode.jssrc/modes/harmonics/HarmonicsMode.jssrc/modes/pan/PanMode.jssrc/core/keyboardControl.js(3 occurrences)src/core/events.jssrc/components/table.js(4 occurrences)src/rendering/cursors.jsImpact
Before:
After:
Benefits
state.marginsis clearer thanstate.axes.marginsTesting
✅ All 65 tests passing with no regressions
✅ TypeScript checking passes
✅ No functional changes - purely structural refactoring
Related
This follows up on #132 and #145 to continue improving the codebase architecture by eliminating unnecessary complexity.