Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test + docs: classical registration toy examples for integration testing purposes #28

Closed
tvercaut opened this issue Jun 16, 2020 · 12 comments
Assignees
Labels
test Issues related to unit-testing (or integration testing).
Milestone

Comments

@tvercaut
Copy link
Member

Such a feature can be a nice simple integration test to ensure for example that the gradients are useable.

A basic toy example could involve translating an image and registering it with itself.

If useful, this quick and dirty notebook could be a source of inspiration:
https://colab.research.google.com/drive/1OmU-jTvWmRRVerc23nsyNz_p8jU3S7wX?usp=sharing

@YipengHu YipengHu self-assigned this Jun 16, 2020
@ucl-candi ucl-candi added the test Issues related to unit-testing (or integration testing). label Jun 16, 2020
YipengHu added a commit that referenced this issue Jun 20, 2020
@YipengHu
Copy link
Member

YipengHu commented Jun 21, 2020

YipengHu added a commit that referenced this issue Jun 21, 2020
YipengHu added a commit that referenced this issue Jun 21, 2020
YipengHu added a commit that referenced this issue Jun 21, 2020
YipengHu added a commit that referenced this issue Jun 21, 2020
YipengHu added a commit that referenced this issue Jun 21, 2020
@YipengHu
Copy link
Member

@zacbaum can you help with converting the two examples to sit please? let me know if you want them to be merged first, though the branch has just been rebased - so should be no big diff.

@YipengHu
Copy link
Member

@zacbaum can you help with converting the two examples to sit please? let me know if you want them to be merged first, though the branch has just been rebased - so should be no big diff.

I've PR anyway ;) please review/approve and you can start a new branch for it.

@YipengHu
Copy link
Member

@zacbaum @NMontanaBrown if adding SITs is too much for R1, I can convert this to a "special demo". What do you think?

@NMontanaBrown
Copy link
Member

@YipengHu Let me review the test and get back to you

@YipengHu
Copy link
Member

YipengHu commented Jul 1, 2020

@YipengHu Let me review the test and get back to you

these two are just examples, there are a few others you can add to cover other functions/modules, such as affine registration, registration on labels/features.

@NMontanaBrown
Copy link
Member

@YipengHu This is cool, but the test works by looking at the plotted output? I think this is easily modifiable. We can incorporate this after unit tests, I will add to timeline if that makes sense?

@NMontanaBrown NMontanaBrown changed the title Add classical registration toy examples for integration testing purposes Test + docs: classical registration toy examples for integration testing purposes Jul 1, 2020
@NMontanaBrown NMontanaBrown added this to the Unit testing milestone Jul 1, 2020
@YipengHu
Copy link
Member

YipengHu commented Jul 1, 2020

Good idea. We have to streamline, if not required by joss, not required for R1.
And it is a cool idea for sit!

@YipengHu
Copy link
Member

YipengHu commented Jul 7, 2020

@NMontanaBrown @zacbaum what's our plan for this? if not before R1, please add post-r1 label.

@NMontanaBrown
Copy link
Member

Still on track to refactor for R1 @YipengHu !

@YipengHu
Copy link
Member

@zacbaum @NMontanaBrown
see #193 we will move some of the code for purpose of one or two demos. we will discuss it again how to make this sit again

  • potentially post-r1

@YipengHu
Copy link
Member

closing this as they have been moved to demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to unit-testing (or integration testing).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants