Skip to content

Fix bug in the GRU gnn layer #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fix bug in the GRU gnn layer #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04acc62
Update layers.py
JesusPinedaC Nov 8, 2022
19bd1a3
Update test_layers.py
JesusPinedaC Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deeptrack/models/gnns/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ def __init__(

# node update layer
self.update_layer = layers.GRU(filters, time_major=True)

self.update_norm = tf.keras.layers.Layer()

def update_node_features(self, nodes, aggregated, learnable_embs, edges):
Combined = tf.reshape(
tf.stack([nodes, aggregated], axis=0), (2, -1, nodes.shape[-1])
Expand Down
14 changes: 14 additions & 0 deletions deeptrack/test/test_layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,20 @@ def test_Masked_FGNN_layer(self):
),
)
self.assertTrue(model.layers[-1], layers.MaskedFGNN)

def test_GRUMPN_layer(self):
block = layers.GRUMPNLayer()
model = makeMinimalModel(
block(96),
input_layer=(
k_layers.Input(shape=(None, 96)),
k_layers.Input(shape=(None, 10)),
k_layers.Input(shape=(None, 2), dtype=tf.int32),
k_layers.Input(shape=(None, 1)),
k_layers.Input(shape=(None, 2)),
),
)
self.assertTrue(model.layers[-1], layers.GRUMPN)

def test_GraphTransformer(self):
block = layers.GraphTransformerLayer()
Expand Down