Skip to content

Conversation

commit111
Copy link
Collaborator

@commit111 commit111 commented Oct 10, 2024

Now using bookworm-slim instead of alpine as the base image for vuejs

Samples Checklist

✅ All good!

@commit111 commit111 requested a review from raphaeltm October 10, 2024 22:29
@raphaeltm
Copy link
Collaborator

@commit111 it looks like you made this branch from another branch that has other stuff like your new React sample. In the future, you should make the new branches from the main branch unless there's a dependency reason. So I merged your other PR that has the OG React sample, but now there are conflicts. Can you please resolve those conflicts before I merge this?

 the commit.

need to resolve conflict for vuejs image change
@commit111
Copy link
Collaborator Author

okay, I've updated it, hopefully it will work now?

@raphaeltm raphaeltm merged commit e22fdeb into main Oct 23, 2024
3 checks passed
@commit111 commit111 deleted the linda-vue-baseimage branch November 19, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants