Add LaunchDarkly JavaScript client typings #11916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ldclient-js/ldclient-js.d.ts Checklist
|
jkodumal
reviewed
Oct 11, 2016
| /** | ||
| * The types of values a feature flag can have. | ||
| */ | ||
| export type LDFlagValue = boolean | string; |
There was a problem hiding this comment.
LDFlagValue could also be an arbitrary JSON object, array, or number. So maybe just any?
jkodumal
reviewed
Oct 11, 2016
| * @returns | ||
| * The flag's value. | ||
| */ | ||
| variation: (key: string, defaultValue?: boolean) => LDFlagValue; |
There was a problem hiding this comment.
The defaultValue should be of type LDFlagValue
|
Thanks @jkodumal - I made the changes you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case 1. Add a new type definition.
--target es6and--noImplicitAnyoptions.-tests.tsor-tests.tsx.I tried to follow the contribution guide 馃榾 The npm package is named the same as the folder, ldclient-js.