Skip to content

GRIDEDIT 1739: mirror multiple rows #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

GRIDEDIT 1739: mirror multiple rows #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe6222
GRIDEDIT-1739: mirror multiple rows
lucacarniato Mar 12, 2025
7055369
Bug Fix
lucacarniato Mar 12, 2025
d5fb977
Account for comments
lucacarniato Mar 13, 2025
651b0c2
Merge branch 'main' into feature/GRIDEDIT-1739_mirror_multiple_rows
lucacarniato Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/MeshKernelNET/Api/IMeshKernelApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,13 +386,15 @@ int CurvilinearLineAttractionRepulsion(int meshKernelId,
/// </summary>
/// <param name="meshKernelId">The id of the mesh state</param>
/// <param name="mirroringFactor">The x coordinate of the first node of the set line</param>
/// <param name="numRowsToGenerate">The number of rows to generate</param>
/// <param name="xFirstGridLineNode">The x coordinate of the first node of the set line</param>
/// <param name="yFirstGridLineNode">The y coordinate of the first node of the set line </param>
/// <param name="xSecondGridLineNode">The x coordinate of the second node of the set line </param>
/// <param name="ySecondGridLineNode">The y coordinate of the second node of the set line </param>
/// <returns>Error code</returns>
int CurvilinearLineMirror(int meshKernelId,
double mirroringFactor,
int numRowsToGenerate,
double xFirstGridLineNode,
double yFirstGridLineNode,
double xSecondGridLineNode,
Expand Down
2 changes: 2 additions & 0 deletions src/MeshKernelNET/Api/MeshKernelApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,13 +393,15 @@ public int CurvilinearLineAttractionRepulsion(int meshKernelId,

public int CurvilinearLineMirror(int meshKernelId,
double mirroringFactor,
int numRowsToGenerate,
double xFirstGridLineNode,
double yFirstGridLineNode,
double xSecondGridLineNode,
double ySecondGridLineNode)
{
return MeshKernelDll.CurvilinearLineMirror(meshKernelId,
mirroringFactor,
numRowsToGenerate,
xFirstGridLineNode,
yFirstGridLineNode,
xSecondGridLineNode,
Expand Down
2 changes: 2 additions & 0 deletions src/MeshKernelNET/Native/MeshKernelDll.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ internal static extern int CurvilinearLineAttractionRepulsion([In] int meshKerne
/// </summary>
/// <param name="meshKernelId">The id of the mesh state</param>
/// <param name="mirroringFactor">The x coordinate of the first node of the set line</param>
/// <param name="numRowsToGenerate">The number of rows to generate</param>
/// <param name="xFirstGridLineNode">The x coordinate of the first node of the set line</param>
/// <param name="yFirstGridLineNode">The y coordinate of the first node of the set line </param>
/// <param name="xSecondGridLineNode">The x coordinate of the second node of the set line </param>
Expand All @@ -435,6 +436,7 @@ internal static extern int CurvilinearLineAttractionRepulsion([In] int meshKerne
[DllImport(MeshKernelDllName, EntryPoint = "mkernel_curvilinear_line_mirror", CallingConvention = CallingConvention.Cdecl)]
internal static extern int CurvilinearLineMirror([In] int meshKernelId,
[In] double mirroringFactor,
[In] int numRowsToGenerate,
[In] double xFirstGridLineNode,
[In] double yFirstGridLineNode,
[In] double xSecondGridLineNode,
Expand Down
2 changes: 1 addition & 1 deletion test/MeshKernelNETTest/Api/MeshKernelCurvilinearTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ public void CurvilinearLineMirrorThroughAPI()

Assert.AreEqual(0, api.CurvilinearSet(id, grid));
// Execute
Assert.AreEqual(0, api.CurvilinearLineMirror(id, 1.2, 0.0, 0.0, 0.0, 50.0));
Assert.AreEqual(0, api.CurvilinearLineMirror(id, 1.2, 1, 0.0, 0.0, 0.0, 50.0));
// Assert
Assert.AreEqual(0, api.CurvilinearGridGetData(id, out curvilinearGrid));

Expand Down