Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on fixed dt leading to negative storage #1406

Closed
visr opened this issue Apr 18, 2024 · 0 comments · Fixed by #1425
Closed

Error on fixed dt leading to negative storage #1406

visr opened this issue Apr 18, 2024 · 0 comments · Fixed by #1425
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Apr 18, 2024

We use isoutofdomain to reject timesteps leading to negative storage. I think this only really works for adaptive timestepping, where it can reduce the dt. For fixed dt it is still possible to get negative storage if you have a Basin with a very large outflow, which steps over our smoothing functions. We should also do this check ourselves in a FunctionCallingCallback, with an informative error message pointing to the Basin node(s) that has negative storage.

@visr visr added the core Issues related to the computational core in Julia label Apr 18, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 18, 2024
@gijsber gijsber moved this from To do to What's next in Ribasim Apr 22, 2024
@elinenauta elinenauta moved this from What's next to Sprint backlog in Ribasim Apr 23, 2024
@SouthEndMusic SouthEndMusic moved this from Sprint backlog to 🏗 In progress in Ribasim Apr 23, 2024
visr pushed a commit that referenced this issue Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant