-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge back #1005
Merge back #1005
Conversation
Co-authored-by: Sam Vente <sam.vente@deltares.nl> Co-authored-by: hboisgon <45457510+hboisgon@users.noreply.github.com> Co-authored-by: Dirk Eilander <dirk.eilander@gmail.com> Co-authored-by: DirkEilander <15379728+DirkEilander@users.noreply.github.com>
Co-authored-by: Sam Vente <savente93@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Sam Vente <savente93@gmail.com>
…860) Co-authored-by: Dirk Eilander <dirk.eilander@gmail.com> Co-authored-by: DirkEilander <15379728+DirkEilander@users.noreply.github.com>
Co-authored-by: hboisgon <45457510+hboisgon@users.noreply.github.com> Co-authored-by: Jaap Langemeijer <33715902+Jaapel@users.noreply.github.com>
Co-authored-by: Tjalling-dejong <tjalling.dejong@deltares.nl> Co-authored-by: Sam Vente <savente93@proton.me> Co-authored-by: Tjalling-dejong <93266159+Tjalling-dejong@users.noreply.github.com> Co-authored-by: Sam Vente <savente93@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Tjalling-dejong <93266159+Tjalling-dejong@users.noreply.github.com> Co-authored-by: Tjalling-dejong <tjalling.dejong@deltares.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't include changes from docs/api.rst
otherwise looks alright
docs/api.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file should not be included, as we have a new structure in v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that, thanks! I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good now!
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
General Checklist
main
Data/Catalog checklist
data/catalogs/predefined_catalogs.yml
has not been modified.data_catalog.yml
files have been chagneddata/chagnelog.rst
has been updatedLF
line endings (done automatically if you usedupdate_versions.py
)Additional Notes (optional)
Add any additional notes or information that may be helpful.