Merge back #1005
Merged
Merge back #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Vente <sam.vente@deltares.nl> Co-authored-by: hboisgon <45457510+hboisgon@users.noreply.github.com> Co-authored-by: Dirk Eilander <dirk.eilander@gmail.com> Co-authored-by: DirkEilander <15379728+DirkEilander@users.noreply.github.com>
Co-authored-by: Sam Vente <savente93@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Sam Vente <savente93@gmail.com>
…860) Co-authored-by: Dirk Eilander <dirk.eilander@gmail.com> Co-authored-by: DirkEilander <15379728+DirkEilander@users.noreply.github.com>
Co-authored-by: hboisgon <45457510+hboisgon@users.noreply.github.com> Co-authored-by: Jaap Langemeijer <33715902+Jaapel@users.noreply.github.com>
Co-authored-by: Tjalling-dejong <tjalling.dejong@deltares.nl> Co-authored-by: Sam Vente <savente93@proton.me> Co-authored-by: Tjalling-dejong <93266159+Tjalling-dejong@users.noreply.github.com> Co-authored-by: Sam Vente <savente93@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Tjalling-dejong <93266159+Tjalling-dejong@users.noreply.github.com> Co-authored-by: Tjalling-dejong <tjalling.dejong@deltares.nl>
savente93
requested changes
Jun 19, 2024
docs/api.rst
Outdated
There was a problem hiding this comment.
The changes in this file should not be included, as we have a new structure in v1
There was a problem hiding this comment.
I missed that, thanks! I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
General Checklist
mainData/Catalog checklist
data/catalogs/predefined_catalogs.ymlhas not been modified.data_catalog.ymlfiles have been chagneddata/chagnelog.rsthas been updatedLFline endings (done automatically if you usedupdate_versions.py)Additional Notes (optional)
Add any additional notes or information that may be helpful.