Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/310 refactor direct analyses to common interface #314

Merged
merged 27 commits into from
Mar 11, 2024
Merged

Chore/310 refactor direct analyses to common interface #314

merged 27 commits into from
Mar 11, 2024

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Mar 8, 2024

No description provided.

@ArdtK ArdtK linked an issue Mar 8, 2024 that may be closed by this pull request
Direct analyses implement the same interface. #310
Closed
6 tasks
ArdtK added 19 commits March 8, 2024 11:59
@ArdtK
chore: add protocol for direct analysis
2b08554
@ArdtK
chore: expand factory
6d3cb80
@ArdtK
chore: rework logic to match direct runner
57b2dd7
@ArdtK
chore: add typehint
2e4b1e2
@ArdtK
chore: remove unused import
c6ba6b0
@ArdtK
chore: add raise if invalid source
245c7bb
@ArdtK
chore: first version of direct damage module
0c392a5
@ArdtK
chore: first version of effectiveness measures module
694ba65
@ArdtK
chore: remove erroneous None in string
1575268
@ArdtK
chore: switch direct analysis runner to new analysis modules
a96dd0f
@ArdtK
Merge remote-tracking branch 'origin/HEAD' into chore/310-refactor-an…
e6a1381 
…alyses-to-common-interface
@ArdtK
test: add unittests for analysis_collection
a25ddd6
@ArdtK
test: add unittests for analysis_factory
ff04a4c
@ArdtK
test: reorganize tests
e37f8c0
@ArdtK
chore: rework effectiveness measures tests
777020d
@ArdtK
chore: rework effectiveness measures tests
ec45944
@ArdtK
chore: remove unused files
8547223
@ArdtK
chore: remove __init__ from protocols
393cfd6
@ArdtK
chore: convert staticmethods in effectivess_measures
ff8c6c3
@ArdtK ArdtK mentioned this pull request Mar 11, 2024
Closed
15 tasks
@ArdtK ArdtK changed the title Chore/310 refactor analyses to common interface Chore/310 refactor direct analyses to common interface Mar 11, 2024
@ArdtK ArdtK requested a review from Carsopre March 11, 2024 10:04
@ArdtK ArdtK marked this pull request as ready for review March 11, 2024 10:08
Carsopre
Carsopre requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising, some remarks throughout the whole PR need to be addressed before merging.

ra2ce/analysis/analysis_factory.py Outdated Show resolved Hide resolved
ra2ce/analysis/analysis_protocol.py Outdated Show resolved Hide resolved
ra2ce/analysis/analysis_protocol.py Outdated Show resolved Hide resolved
ra2ce/analysis/direct/analysis_direct_protocol.py Outdated Show resolved Hide resolved
ra2ce/analysis/direct/direct_damage.py Outdated Show resolved Hide resolved
ra2ce/analysis/direct/effectiveness_measures.py Outdated Show resolved Hide resolved
ra2ce/analysis/direct/effectiveness_measures.py Outdated Show resolved Hide resolved
ra2ce/runners/indirect_analysis_runner.py Show resolved Hide resolved
tests/analysis/direct/damage_calculation/test_damage_network_events.py Outdated Show resolved Hide resolved
tests/analysis/direct/test_effectiveness_measures.py Outdated Show resolved Hide resolved
@ArdtK ArdtK merged commit 8e6114b into master Mar 11, 2024
3 checks passed
@ArdtK ArdtK deleted the chore/310-refactor-analyses-to-common-interface branch March 11, 2024 12:51
Carsopre pushed a commit that referenced this pull request Apr 12, 2024
@ArdtK
Merge pull request #314 from Deltares/chore/310-refactor-analyses-to-…
7ff8e28 
…common-interface

chore: 310 refactor direct analyses to common interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carsopre Carsopre Carsopre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct analyses implement the same interface.
2 participants
@ArdtK @Carsopre