Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the persistence module invalidates existing data when it ch… #133

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

umbernhard
Copy link
Collaborator

This fixes the persistence class to properly update its database URLs when they change. This is essentially only necessary when testing, as the class is static and final (and the URL shouldn't change in prod).

Copy link
Member

@vteague vteague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, thanks - I'm getting all tests passing, for the first time since we started work on corla 🎉

@vteague vteague merged commit a1b2d7c into main Jun 22, 2024
1 check passed
@vteague vteague deleted the persistence-fix branch June 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants