Fix property_cache_once_per_frame #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of the "property_cache_once_per_frame" decorator doesn't work with multiple instances of the same class. This is due to the cache being stored to the function itself, rather than to the individual object it's being called on. Address this issue by adding a parameter to the decorator, which can be used to define where the cache should be stored on the object, and store the cache there. This allows multiple bots to co-exist in a single process without conflicting caches.
|
Continuation of #210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of the "property_cache_once_per_frame" decorator
doesn't work with multiple instances of the same class. This is due to
the cache being stored to the function itself, rather than to the
individual object it's being called on.
Address this issue by adding a parameter to the decorator, which can
be used to define where the cache should be stored on the object, and
store the cache there.
This allows multiple bots to co-exist in a single process without
conflicting caches.