Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort and Pause (under the gcode window) in Candle 1.2 #541

Open
pad73 opened this issue Mar 15, 2022 · 13 comments
Open

Abort and Pause (under the gcode window) in Candle 1.2 #541

pad73 opened this issue Mar 15, 2022 · 13 comments

Comments

@pad73
Copy link

pad73 commented Mar 15, 2022

Versions

  • Candle version: 1.2.15
  • Firmware version: 1.1h

I found in Candle 1.2 some different behaviour of the buttons Abort and Pause. In Candle 1.1. after click on the button action was immeditatelly, when click on Pause then program stop (HOLD), when click on Abort program stop and terminate immeditatelly.
BUT
In 1.2 (15) version after clicking on both these buttons program continue with actually loaded data and goes to the pause or stop after moving by these last datas. It means there is long time between click and action. It is very uncomfortable and may be, little dangerous. Only way with pause is to use HOLD button (that is OK, it works perfectly). But to terminate program imediatelly the way is only one, RESET. Not so good because it means loosing working coordinates. Of course you can put it back using stored coordinates using G92. But as I wrote before, it is very uncomfortable.

And I found that reaction to click on moving buttons (x y z) is slower than Candle 1.1

Can anybody explain it? Is it any settings to change buttons behaviour?

Now, when I´m writing this text I have idea to use shortcuts because there is possibility to add shortcut to Hold and Abort, but I can test it just now. Otherwise if it will work I will use it, but original buttons funciton will stay strange to me.

@pad73
Copy link
Author

pad73 commented Mar 16, 2022

Yesterday I tested function of Pause and Abort using shortcuts ... works the same as when using buttons. This is not acceptable for me so I´m leaving 1.2 version, and I´m going back to 1.1. This 1.2 version brings some new nice tools (scripts, working area borders, ...), but changed more important thing to unusable.
If anybody has solution let me know please.

@rjcamatos
Copy link

rjcamatos commented Mar 16, 2022 via email

@pad73
Copy link
Author

pad73 commented Mar 16, 2022

You wrote nothing new, but how to solve it? It seems to me the base code for Candle 1.2 was reprogramed to use some new functions and it brings these issues.

@mar0x
Copy link

mar0x commented Mar 16, 2022

Can anybody explain it?

According to source code, the "Pause" button in "Experimental" branch (v 1.2) changes the sender state i.e. affects only commands from the file to send. The commands which was sent are processed by CNC as usual. This why you experience the delay before CNC stops.
As far as I understand, the "Hold" button was introduced exactly to immediately pause the CNC (source).

In stable version (v 1.1), the "Pause" send to CNC "!" character processed by CNC right as "Hold" button in v 1.2.

The "Abort" button in "Experimental" branch (v 1.2) just enqueue "M2" command. So CNC will process the commands which was already sent and then stop. Again, with delay.
The "Reset" button in "Experimental" branch (v 1.2) does the actions similar to "Abort" in stable version.

Is it any settings to change buttons behaviour?

I can't see in source code the way to change it's behaviour. Just use "Hold" button to immediately pause CNC.
Regarding "Reset" behaviour difference, could you confirm the difference in v1.1 "Abort" and v1.2 "Reset" button result?

@pad73
Copy link
Author

pad73 commented Mar 16, 2022

Thank you for explaining. Hold is Ok, there isn't problem. But to use reset as abort program isn't the best way IMHO.

@mar0x
Copy link

mar0x commented Mar 16, 2022

"Reset" in v1.2 does exactly the same as "Abort" in v1.1: send "soft-reset" command. I've tested - machine and work coordinates remains unchanged. Could you please confirm it?

This is the question to @Denvi what is the purpose of new "Pause" and "Abort" in v1.2 ?

@pad73
Copy link
Author

pad73 commented Mar 17, 2022

Thank for your answer. I will test it evening. I used it yet but it looks strange to me. But OK, I will test it again focused on.

@pad73
Copy link
Author

pad73 commented Mar 17, 2022

Sorry for my English 😉 https://youtu.be/mM8WeGjbDXs

@mar0x
Copy link

mar0x commented Mar 17, 2022

Thank you for video! The difference is obvious.

I'm sorry, I was wrong about equivalence of "Abort" in 1.1 and "Reset" in 1.2. This is not true.

"Abort" in 1.1 immediately send "!" (which is the same as "Pause" in 1.1 or "Hold" in 1.2) and m_aborting flag raised.
The only way to send "!" in 1.2 is "Hold" button.

"Reset" button in "Control" panel should behave same way in 1.1 and 1.2.

@pad73
Copy link
Author

pad73 commented Mar 17, 2022

Result of it is that isn't cool ... It is quite stupid

@mar0x
Copy link

mar0x commented Mar 17, 2022

Sad but true.
Consider following sequence for "Abort":

  1. "Halt" for immediate stop the machine (remember work coordinates to check);
  2. "Reset" (in "Control" panel) to stop processing file;
  3. "Restore Origin" to restore work coordinates (check the restored coordinates from the step 1);

Agree, this is not as simple as one button click, but should work.

Maybe @Denvi can suggest something different...

@pad73
Copy link
Author

pad73 commented Mar 18, 2022

Easy way - let it works as before 😉

@SinkaGit
Copy link

SinkaGit commented Mar 1, 2024

Could you please fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants