chore: Update depends and use test token #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieSinn
force-pushed
the
update-php-deps
branch
from
caef755 to
c850fe7
Compare
suthar26
reviewed
Mar 12, 2025
|
|
||
| $structResult = self::$openFeatureClient->getObjectValue('php-sdk-struct', array(), self::$context); | ||
| self::assertEquals(array("key"=>"value", "number"=>1, "bool"=>true, "nested"=>array("key"=>"value")), $structResult); | ||
| $structResult = self::$openFeatureClient->getObjectValue('test-json-variable', array(), self::$context); |
There was a problem hiding this comment.
should we not test this with an object response?
There was a problem hiding this comment.
Not really - we can't guarantee the format given the source test projects change all the time - this just prevents us from breaking things; I'm confident that the other tests provide safety on this (namely test harness)
jonathannorris
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.