Skip to content

feat: added evaluation hooks for php #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

feat: added evaluation hooks for php #131

merged 1 commit into from
Jul 16, 2025

Conversation

jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Jul 15, 2025 •
edited
Loading

Changes

  • added evaluation hooks for php

@jsalaber jsalaber force-pushed the COR-3451-php-hooks-eval branch from 810460e to 025b90b Compare July 15, 2025 20:12
@jsalaber jsalaber requested review from a team and JamieSinn July 15, 2025 20:24
suthar26
suthar26 reviewed Jul 16, 2025
View reviewed changes
JamieSinn
JamieSinn reviewed Jul 16, 2025
View reviewed changes
@jsalaber jsalaber force-pushed the COR-3451-php-hooks-eval branch from 025b90b to ba6e727 Compare July 16, 2025 17:47
@jsalaber jsalaber requested review from JamieSinn and suthar26 July 16, 2025 17:53
JamieSinn
JamieSinn reviewed Jul 16, 2025
View reviewed changes
test/Api/HookTest.php Outdated

$options = new DevCycleOptions(false, null, null, [], [$hook]);
$this->client = new DevCycleClient(
sdkKey: getenv("dvc_server_token_hash") ?: "dvc_server_test_key",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting the env variable - you had the right env var but didn't update the default

Suggested change
sdkKey: getenv("dvc_server_token_hash") ?: "dvc_server_test_key",
sdkKey: getenv("DEVCYCLE_SERVER_SDK_KEY") ?: "dvc_server_token_hash",

@jsalaber jsalaber force-pushed the COR-3451-php-hooks-eval branch from ba6e727 to d44d8b7 Compare July 16, 2025 17:56
@jsalaber jsalaber requested a review from JamieSinn July 16, 2025 17:56
JamieSinn
JamieSinn reviewed Jul 16, 2025
View reviewed changes
@jsalaber jsalaber force-pushed the COR-3451-php-hooks-eval branch from d44d8b7 to 767ea54 Compare July 16, 2025 18:11
@jsalaber jsalaber requested a review from JamieSinn July 16, 2025 18:11
@jsalaber jsalaber enabled auto-merge (squash) July 16, 2025 18:13
@jsalaber jsalaber merged commit d7f6b7c into main Jul 16, 2025
6 checks passed
@jsalaber jsalaber deleted the COR-3451-php-hooks-eval branch July 16, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieSinn JamieSinn JamieSinn approved these changes

@suthar26 suthar26 suthar26 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsalaber @JamieSinn @suthar26