Skip to content

Conversation

jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Jul 31, 2025

Changes

  • added eval reason support for php

@jsalaber jsalaber requested a review from a team as a code owner July 31, 2025 17:13
@kaushalkapasi
Copy link
Contributor

kaushalkapasi commented Jul 31, 2025

Update the unit test assertion for the variableByKey test to ensure eval is properly returned?

@jsalaber jsalaber marked this pull request as draft July 31, 2025 17:16
@jsalaber
Copy link
Contributor Author

still WIP, needed to see test harness fails @kaushalkapasi

@jsalaber jsalaber force-pushed the COR-3432-add-eval-reason-support branch from 58317aa to d451abe Compare July 31, 2025 19:28
@jsalaber jsalaber force-pushed the COR-3432-add-eval-reason-support branch from d451abe to 4e6d25d Compare July 31, 2025 19:34
@jsalaber jsalaber requested a review from kaushalkapasi July 31, 2025 20:50
@jsalaber jsalaber force-pushed the COR-3432-add-eval-reason-support branch 2 times, most recently from f54c3f9 to 40b5fa0 Compare July 31, 2025 20:56
@jsalaber jsalaber marked this pull request as ready for review July 31, 2025 20:58
@jsalaber jsalaber requested a review from a team July 31, 2025 20:59
@jsalaber jsalaber force-pushed the COR-3432-add-eval-reason-support branch from 40b5fa0 to 862eb75 Compare August 1, 2025 14:21
@kaushalkapasi kaushalkapasi merged commit 5f870e9 into main Aug 6, 2025
4 of 6 checks passed
@kaushalkapasi kaushalkapasi deleted the COR-3432-add-eval-reason-support branch August 6, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants