SelectBox: should not throw an error if its detached template is re-mounted by a framework (T1178295) #25467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxvladislavvolkov
previously approved these changes
Sep 1, 2023
VasilyStrelyaev
force-pushed
the
no-excessive-onrendered-on-remount
branch
from
30392e3
to
a0a62c1
Compare
VasilyStrelyaev
changed the title
VasilyStrelyaev
changed the title
VasilyStrelyaev
requested review from
a team and
dxvladislavvolkov
and removed request for
ivanblinov2k17
ksercs
changed the title
ksercs
previously approved these changes
Sep 8, 2023
| @@ -354,8 +352,9 @@ const DropDownEditor = TextBox.inherit({ | |||
| model: data, | |||
| container: getPublicElement($templateWrapper), | |||
| onRendered: () => { | |||
| this._fieldRenderQueueLength--; | |||
| if(this._fieldRenderQueueLength !== 0) { | |||
| const renderedInRoot = !!this.$element().find($templateWrapper).length; | |||
There was a problem hiding this comment.
[minor]
Suggested change
| const renderedInRoot = !!this.$element().find($templateWrapper).length; | |
| const isRenderedInRoot = !!this.$element().find($templateWrapper).length; |
ksercs
approved these changes
Sep 11, 2023
VasilyStrelyaev
requested review from
ivanblinov2k17
and removed request for
dxvladislavvolkov
ivanblinov2k17
approved these changes
Sep 12, 2023
VasilyStrelyaev
added a commit
to VasilyStrelyaev/DevExtreme
that referenced
this pull request
Sep 12, 2023
…ounted by a framework (T1178295) (DevExpress#25467)
VasilyStrelyaev
added a commit
to VasilyStrelyaev/DevExtreme
that referenced
this pull request
Sep 12, 2023
…ounted by a framework (T1178295) (DevExpress#25467)
|
________________________________
From: Vasily Strelyaev ***@***.***>
Sent: Tuesday, September 12, 2023 12:46
To: DevExpress/DevExtreme ***@***.***>
Cc: Eugeniy Kiyashko (DevExpress) ***@***.***>; Review requested ***@***.***>
Subject: Re: [DevExpress/DevExtreme] SelectBox: should not throw an error if its detached template is re-mounted by a framework (T1178295) (PR #25467)
Merged #25467<#25467> into 23_2.
—
Reply to this email directly, view it on GitHub<#25467 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADXWK6BY6QQMR6QMWRSCAJTX2AVO5ANCNFSM6AAAAAA4DFVPKQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.