Skip to content

Conversation

jjoonleo
Copy link
Contributor

Describe your changes

  • change login to use idToken
  • change web login to user renderButton method in GoogleSignIn package

Issue ticket number and link

Closes #198

@jjoonleo jjoonleo requested a review from SeoHyeonSim March 19, 2025 05:22
@jjoonleo jjoonleo self-assigned this Mar 19, 2025
@jjoonleo jjoonleo linked an issue Mar 19, 2025 that may be closed by this pull request
Copy link

Visit the preview URL for this PR (updated for commit d5e2ea0):

https://ontime-c63f1--pr202-198-change-google-lo-ns3wgywj.web.app

(expires Wed, 26 Mar 2025 05:25:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

Copy link

Visit the preview URL for this PR (updated for commit d5e2ea0):

https://on-time-front-widgetbook--pr202-198-change-google-lo-xkoqkt5v.web.app

(expires Wed, 26 Mar 2025 05:26:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

SeoHyeonSim
SeoHyeonSim previously approved these changes Mar 19, 2025
@jjoonleo jjoonleo dismissed SeoHyeonSim’s stale review March 19, 2025 10:26

The merge-base changed after approval.

@jjoonleo jjoonleo merged commit 7f9ac20 into main Mar 19, 2025
6 checks passed
@jjoonleo jjoonleo deleted the 198-change-google-login-to-use-idtoken branch March 19, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Google Login to Use IdToken
2 participants