Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

644 cicd validate failure argument #758

Closed
wants to merge 5 commits into from

Conversation

crazynewidea
Copy link
Contributor

Description

Added optional aac validate --fail-on-warnings parameter, which causes validation to fail when warnings are encountered

Linked Items:

Closes/Fixes/Resolves #644

Checklist:

  • I updated project documentation to reflect my changes.
  • [ X] My changes generate no new warnings.
  • I updated new and existing unit tests to account for my changes.
  • [ X] I linked the associated item(s) to be closed.
  • [X ] I bumped the version.
  • I added the labels corresponding to my changes.

@crazynewidea crazynewidea linked an issue Nov 28, 2023 that may be closed by this pull request
1 task
@crazynewidea
Copy link
Contributor Author

Pull Request #758 was submitted for work in the 644-cicd-validate-failure-argument branch which completes this Issue. However, another Pull Request #714 also contains work that implements a fail-on-warn feature. This can be observed in the following locations:

  • python/src/aac/plugins/check/init.py lines 21, 26
  • python/src/aac/plugins/check/check_impl.py lines 19, 207-208
  • docs/source/project_documentation/plugins/check.md lines 15, 28
  • python/src/aac/plugins/check/checkaac.aac line 17

For this reason, I will cancel PR #758, since this Issue is already addressed in PR #714.

@lizzcondrey
Copy link
Collaborator

@crazynewidea good to delete the original branch of this PR as well?

@lizzcondrey lizzcondrey deleted the 644-cicd-validate-failure-argument branch February 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD Validate Failure Argument
2 participants