Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failure to access clipboard in MacOS #1205

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fixed failure to access clipboard in MacOS #1205

merged 1 commit into from
Jun 17, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 12, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1203

It seems like in some cases, the clipboard API isn't invoked from the Ui thread, causing an internal error because it needs it to access the clipboard. It mainly impacts text box.

What is the new behavior?

Switch to the UI thread before accessing the clipboard.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux June 12, 2024 03:59
@veler veler linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@btiteux btiteux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems good, but I can't test it, so I'm going to trust you on this :)

@veler veler merged commit 8fe6c21 into main Jun 17, 2024
2 of 3 checks passed
@veler veler deleted the fix1203 branch June 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacOS] Paste Shortcut is not working
2 participants