Windowed presentations #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I needed a windowed presentation option for video calls, so added a new settings toggle and the necessary conditional presentation logic.
Full screen presentations must be explicitly disabled by the user via settings:
Implementation Details
fullscreenPresentationEnabled
setting (defaulttrue
) with UI toggle and descriptive copy so presenters can disable automatic fullscreen.presentationUsesFullscreen
per session, conditionally requesting fullscreen and setting up modal observer /onfullscreenchange
only when fullscreen is requested.endPresentation
even in windowed mode;endPresentation
now early-returns when already exited to avoid double teardown.How to Test