-
Notifications
You must be signed in to change notification settings - Fork 25
PKU2U protocol implementation #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspi: pku2u: move config in separate file (module);
sspi: negotiate: improve negotiation algorithm;
ffi: add Pku2u package support;
ffi: format code;
…m the certificate; remove hardcoded authenticator checksum
…lation with the feature
sspi: credssp: fix negotokens on pub key auth stage;
…ation on Linus OS; ffi: fix compilation on Linux OS;
sspi: fix merge conflicts; improve negotiate module; fix compilation without features; ffi: fix merge conflicts;
e69cfe6
to
a61031a
Compare
RRRadicalEdward
commented
Nov 1, 2022
CBenoit
reviewed
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! 👍
…in the negotiate module
CBenoit
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Alex! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of the PKU2U authorization protocol in the
sspi-rs
and updated FFI-bindings to support this protocol.Also, I've improved the Negotiate module: now if a user will try to log in under the
AzureAD
domain then it automatically will switch to the PKU2U.Important note: for the PKU2U Azure AD certificate is needed with the corresponding private key. The current implementation will try to extract them from the Windows Certificate Store using WinAPI bindings. Requirements for the certificate:
MS-Organization-P2P-Access
likeMS-Organization-P2P-Access [2021]
orMS-Organization-P2P-Access [2022]
;ClientAuth
extended key usage has to be present.Used Docs & References: