-
Notifications
You must be signed in to change notification settings - Fork 66
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
#include
-ing these files in your shader causes a boost preprocessor error when compiling the shader in NSC
[ERROR]: boost::wave::preprocess_exception exception caught. warning: unbalanced #if/#endif in include file
due to the ifdefs
around each #pragma dxc
call
Nabla/include/nbl/builtin/hlsl/tgmath/impl.hlsl
Lines 542 to 549 in a5f2718
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic push | |
#pragma dxc diagnostic ignored "-Wliteral-range" | |
#endif | |
const T thresholds[4] = { 0, 5e4, 1e36, 1e305 }; // threshold values gotten from testing when the function returns nan/inf | |
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic pop | |
#endif |
Nabla/include/nbl/builtin/hlsl/tgmath/impl.hlsl
Lines 591 to 598 in a5f2718
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic push | |
#pragma dxc diagnostic ignored "-Wliteral-range" | |
#endif | |
const T thresholds[4] = { 0, 2e4, 1e6, 1e15 }; // threshold values gotten from testing when the function returns nan/inf/1 | |
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic pop | |
#endif |
Nabla/include/nbl/builtin/hlsl/bxdf/common.hlsl
Lines 942 to 953 in a5f2718
assert(x >= T(0.999) && y >= T(0.999)); | |
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic push | |
#pragma dxc diagnostic ignored "-Wliteral-range" | |
#endif | |
const T thresholds[4] = { 0, 5e5, 1e6, 1e15 }; // threshold values gotten from testing when the function returns nan/inf/1 | |
#ifdef __HLSL_VERSION | |
#pragma dxc diagnostic pop | |
#endif | |
if (x+y > thresholds[mpl::find_lsb_v<sizeof(T)>]) | |
return T(0.0); |
Will comment them out for now and link temp fix commit to this issue.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working