Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parameter label and value lists as dictionaries #27

Closed
jarmarshall opened this issue Sep 20, 2017 · 5 comments
Closed

Refactor parameter label and value lists as dictionaries #27

jarmarshall opened this issue Sep 20, 2017 · 5 comments
Assignees
@joefresna @jarmarshall
Labels
enhancement

Comments

@jarmarshall
Copy link
Contributor

In views, etc.
joefresna pushed a commit that referenced this issue Sep 27, 2017
Now Controllers store parameters' values and names only in the widget…
a82e9a2 
…Dict as proposed in issue #27
@jarmarshall
Copy link
Contributor Author

Can this be closed now?

@joefresna
Copy link
Contributor

I think that there are still the lists:
paramValues
and
paramNames

which are deprecated but still around... I think they should be removed/replaced...

@joefresna joefresna assigned jarmarshall and unassigned joefresna Oct 24, 2017
@joefresna joefresna mentioned this issue Oct 27, 2017
Closed
@jarmarshall
Copy link
Contributor Author

These lists should not be removed - they are used for setting parameter values in standalone views (and in the future in partial controllers; issue #53)
However they could usefully be refactored into a single dictionary

@joefresna joefresna mentioned this issue Dec 27, 2017
Closed
@joefresna
Copy link
Contributor

if possible, it would be convenient to use the _fixedParams dictionary to store the fixed param (_fixedParams is currently in use for SSA and MA to handle advanced options)

joefresna pushed a commit that referenced this issue May 22, 2018
Massive refactoring of most classes.
35d6b11 
Controllers accept `initWidgets` dictionary where keys are the free-parameter or any other specific parameter, and values are four values as [initial-value, min-value, max-value, step-size] (this solves issue #14 and issue #5).

Integrate the `MuMoTdefault` class into all controllers (this solves issue #52).

Finally removed the terribly ugly paramNames and paramValues lists. They have been substituted in the `MuMoTview` by a single dictionary `_fixedParams` (this solves issue #27).
@joefresna joefresna self-assigned this May 22, 2018
@joefresna
Copy link
Contributor

I couldn't stand this anymore. Solved with commit 35d6b11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joefresna joefresna

@jarmarshall jarmarshall

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joefresna @jarmarshall