Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if the systemSize or plotLimits are specified (as input parameter) in the controller constructor, the generated bookmark string shows duplicate text AND an incorrect formatted output #88

Closed
joefresna opened this issue Dec 18, 2017 · 2 comments
Assignees

Comments

@joefresna
Copy link
Contributor

No description provided.

@joefresna
Copy link
Contributor Author

to correct the _get_bookmarks_params

@joefresna joefresna self-assigned this Dec 18, 2017
joefresna pushed a commit that referenced this issue Dec 27, 2017
* implemented bookmarks for SSA and MA based on controllers (it solves issue #28)

* SSA and MA do not create widgets for input parameters (also advanced options) in agreement with the partial controller design (this solves issue #53)

* SSA and MA continue to implement and support the function _printStandaloneViewCmd() which generates text for creation of the standalone view (issue #28)

* fixed bug #88, if the systemSize or plotLimits are specified (as input parameter) in the controller constructor, the generated bookmark string shows a correct output

* the input parameters of functions multiagent() and SSA() are checked if are correct through the support functions _parse_input_keyword_for_numeric_widgets() and _parse_input_keyword_for_boolean_widgets() (these functions could help issue #14, #5, and #52)

* functions multiagent() and SSA() accept as parameter the 'initWidgets' dictionary where keys are any free-parameter or any other specific parameter, and values are four values as [initial-value, min-value, max-value, step-size]. This is useful to set the initial parameter values (it solves issue #14 for SSA and MA)
@joefresna
Copy link
Contributor Author

Solved with commit eef3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant