Skip to content

Conversation

dan-fernandes
Copy link
Contributor

Separates what (I think) should be two commands, which is the default in StompTransport.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #158 (b2edfe7) into main (782ed69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   83.36%   83.37%           
=======================================
  Files          24       24           
  Lines        2423     2424    +1     
  Branches      440      440           
=======================================
+ Hits         2020     2021    +1     
  Misses        284      284           
  Partials      119      119           

Copy link
Contributor

@rjgildea rjgildea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a very minor nitpick, this is probably fine and makes the code a little more readable 👍

Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
@dan-fernandes dan-fernandes merged commit 802f496 into main Nov 25, 2022
@dan-fernandes dan-fernandes deleted the PikaTransport-Readability-Tweak branch November 25, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants