Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sessionspaces namespace-controller for vcluster #11

Merged
merged 23 commits into from
Jun 12, 2024
Merged

Add Sessionspaces namespace-controller for vcluster #11

merged 23 commits into from
Jun 12, 2024

Conversation

iamvigneshwars
Copy link
Contributor

@iamvigneshwars iamvigneshwars commented May 23, 2024 •
edited
Loading

  • create/delete session namespace
  • batch query LDAP database to get gid
  • create configmap with gid and session info
  • helm chart

@iamvigneshwars iamvigneshwars added enhancement New feature or request rust Pull request that updates Rust code labels May 23, 2024
@iamvigneshwars iamvigneshwars self-assigned this May 23, 2024
@iamvigneshwars iamvigneshwars requested a review from garryod May 23, 2024 14:29
@iamvigneshwars iamvigneshwars marked this pull request as ready for review May 23, 2024 14:29
garryod
garryod requested changes May 23, 2024
View reviewed changes
Copy link
Member

@garryod garryod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, the development environment and deployment have room to be simplified in a few places, and definitely needs some tests, but the actual code looks good to go

@iamvigneshwars iamvigneshwars marked this pull request as draft May 24, 2024 10:50
@iamvigneshwars iamvigneshwars force-pushed the sessionspaces branch 3 times, most recently from 9b59f3b to c1bf016 Compare May 30, 2024 16:02
@iamvigneshwars iamvigneshwars force-pushed the sessionspaces branch 7 times, most recently from bd008a5 to 072b47c Compare June 4, 2024 08:41
@iamvigneshwars iamvigneshwars marked this pull request as ready for review June 4, 2024 08:46
@iamvigneshwars iamvigneshwars requested a review from garryod June 4, 2024 08:47
garryod
garryod requested changes Jun 4, 2024
View reviewed changes
garryod
garryod requested changes Jun 4, 2024
View reviewed changes
@iamvigneshwars iamvigneshwars force-pushed the sessionspaces branch 2 times, most recently from acbcbaa to c6b4009 Compare June 4, 2024 10:42
garryod
garryod requested changes Jun 4, 2024
View reviewed changes
garryod
garryod requested changes Jun 10, 2024
View reviewed changes
garryod
garryod reviewed Jun 11, 2024
View reviewed changes
garryod
garryod reviewed Jun 11, 2024
View reviewed changes
garryod
garryod previously approved these changes Jun 11, 2024
View reviewed changes
@iamvigneshwars
Sessions namespace controller - Queries ISPyB database, creates/delet…
7a32d3f 
…es namespaces with session names, creates roles and service accounts
@iamvigneshwars
Dockerfile and container github workflow
4b459d4
@iamvigneshwars
Sessionspaces helm chart
12a6ee7
@iamvigneshwars
Add clusterrole, clusterrolebindings, add permissions, ispyb-secret
209a95f
@iamvigneshwars
Update README.md
66d8bb8
@iamvigneshwars
Misc changes to dev environment and helm charts
467c246
@iamvigneshwars
Test DB fetch
94b3999
@iamvigneshwars
Add test to fetch from bl_sessions, proposals, persons from a mock da…
8079221 
…tabase
@iamvigneshwars
Add test for namespace creating/deletion using mock api server
2eebbf1
@iamvigneshwars
Create policy configmap - Base
bc36609
@iamvigneshwars
Add ldap search to get gidnumber for sessions
d1a2e11
@iamvigneshwars
Create configmap with session info and gidNumber, ignore sessions wit…
4fc6451 
…h visit zero or null
@iamvigneshwars
Remove serviceaccount creation for visit-members and workflow
2218fc2
@iamvigneshwars
Document installing vcluster and kubectl inside the devcontainer
02d3536
@iamvigneshwars
Move devcontianer into sessionspaces
7d2806b
@iamvigneshwars
Misc changes
3c6fab7
@iamvigneshwars
Remove clusterrole creation, move ldap to permissionables
3d9dc56
@iamvigneshwars
Remove clusterrole creation, move ldap to permissionables
1ae70f4
@iamvigneshwars
feat: add support to update gidnumber
2a0ee5d
@iamvigneshwars
Misc changes to Dockerfile and charts
c2193bf
@iamvigneshwars
feat: Batch LDAP queries
3f96e7e
@iamvigneshwars
update: fetch all posix attributes and map with sessions downstream
f56813e
@iamvigneshwars
refactor and misc changes
ee5f878
@iamvigneshwars iamvigneshwars requested a review from garryod June 11, 2024 16:00
@iamvigneshwars iamvigneshwars merged commit 053f8eb into main Jun 12, 2024
14 checks passed
@garryod garryod deleted the sessionspaces branch July 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

Assignees

@iamvigneshwars iamvigneshwars

Labels
enhancement New feature or request rust Pull request that updates Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvigneshwars @garryod