Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterRole Templates for Visit Member and Argo Workflows #19

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add ClusterRole Templates for Visit Member and Argo Workflows #19

merged 1 commit into from
Jun 10, 2024

Conversation

iamvigneshwars
Copy link
Contributor

No description provided.

@iamvigneshwars iamvigneshwars added enhancement New feature or request helm Pull request that updates Helm charts labels Jun 6, 2024
@iamvigneshwars iamvigneshwars requested review from daurer and garryod June 6, 2024 09:11
@iamvigneshwars iamvigneshwars self-assigned this Jun 6, 2024
garryod
garryod approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Formatting is a bit inconsistent - we should add linting for this in a separate PR

@iamvigneshwars iamvigneshwars merged commit 20c258b into main Jun 10, 2024
12 checks passed
@garryod garryod deleted the clusterroles branch July 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

@daurer daurer Awaiting requested review from daurer

Assignees

@iamvigneshwars iamvigneshwars

Labels
enhancement New feature or request helm Pull request that updates Helm charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvigneshwars @garryod