Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kyverno policy to generate serviceaccounts and rolebindings #25

Merged
merged 3 commits into from
Jun 17, 2024
Merged

add kyverno policy to generate serviceaccounts and rolebindings #25

merged 3 commits into from
Jun 17, 2024

Conversation

iamvigneshwars
Copy link
Contributor

Add kyverno policy for generating ServiceAccount and RoleBindings whenever a ConfigMap created by the sessionspaces controller.

@iamvigneshwars
add kyverno policy to generate serviceaccounts and
74d2f5c 
rolebindings for argo-workflow and visit-member
@iamvigneshwars iamvigneshwars added enhancement New feature or request helm Pull request that updates Helm charts labels Jun 13, 2024
@iamvigneshwars iamvigneshwars requested a review from garryod June 13, 2024 11:45
@iamvigneshwars iamvigneshwars self-assigned this Jun 13, 2024
garryod
garryod suggested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs testing though, can discuss how in person

@iamvigneshwars iamvigneshwars marked this pull request as draft June 14, 2024 10:14
@iamvigneshwars iamvigneshwars force-pushed the kyverno-generate-sa branch 22 times, most recently from 122cb5f to 950a8c1 Compare June 14, 2024 13:02
@iamvigneshwars iamvigneshwars requested a review from garryod June 14, 2024 13:06
@iamvigneshwars iamvigneshwars marked this pull request as ready for review June 14, 2024 13:06
@iamvigneshwars iamvigneshwars marked this pull request as draft June 14, 2024 13:07
@iamvigneshwars iamvigneshwars force-pushed the kyverno-generate-sa branch 3 times, most recently from 8b1edb6 to ce826e8 Compare June 14, 2024 13:20
@iamvigneshwars iamvigneshwars marked this pull request as ready for review June 14, 2024 13:23
garryod
garryod suggested changes Jun 14, 2024
View reviewed changes
@iamvigneshwars iamvigneshwars marked this pull request as draft June 17, 2024 08:49
@iamvigneshwars iamvigneshwars force-pushed the kyverno-generate-sa branch 3 times, most recently from a06a03f to b0a6dce Compare June 17, 2024 08:59
@iamvigneshwars iamvigneshwars marked this pull request as ready for review June 17, 2024 09:13
garryod
garryod suggested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@garryod garryod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one comment on waiting for resources

@garryod garryod merged commit 8e5e26e into main Jun 17, 2024
17 checks passed
@garryod garryod deleted the kyverno-generate-sa branch July 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

Assignees

@iamvigneshwars iamvigneshwars

Labels
enhancement New feature or request helm Pull request that updates Helm charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvigneshwars @garryod