Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor performance/usability for editing archives #520

Closed
CirnoT opened this issue Oct 9, 2021 · 3 comments
Closed

Poor performance/usability for editing archives #520

CirnoT opened this issue Oct 9, 2021 · 3 comments

Comments

@CirnoT
Copy link
Contributor

CirnoT commented Oct 9, 2021

Currently, in order to edit archive one has to open the Archive Overview page which loads all thumbnails. For archives with 200+ pages this can (and does) slow web browser as it is now forced to render and downscale hundreds of potentially 1MB+ images.

I believe that we used to have Edit Archive Metadata button directly, why was it hidden behind such a low performance endpoint? I understand that the amount of options is growing however I feel like this should definitely be solved. Possibly we could reuse and enhance image resizing to serve dynamic thumbnails (200px or so in size) instead of full images?

Additionally, I find it increasingly annoying that there is no Back button from edit screen.

@Difegue
Copy link
Owner

Difegue commented Oct 9, 2021

Keep in mind the context menu also has a shortcut to the edit page -- I'll agree that the link should also be easily reachable through the reader.

The overview having poor performance for large tanks is something I'd like to fix, see #514.

I've thought about using the resize functions to save on bandwidth before, but considered they'd probably eat up too much CPU power if having to resize 200+ pages at once.

I think adding incremental loading to the overview to fix the immediate performance penalty is a must-do, and hopefully I can add resized thumbnails to the mix later on.

@CirnoT
Copy link
Contributor Author

CirnoT commented Oct 10, 2021

Keep in mind the context menu also has a shortcut to the edit page -- I'll agree that the link should also be easily reachable through the reader.

The context menu isn't available once the archive is opened. I find myself in need of going into edit page more often AFTER opening archive than before (and of course going back to results is no-go either because LRR doesn't remember it)

@Difegue
Copy link
Owner

Difegue commented Jan 5, 2022

I've updated the overlay to use the new thumbnail APIs, which will make it avoid loading the full images from now on.

@Difegue Difegue closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants