Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] return to library button logic is not intuitive enough #546

Closed
frankli998 opened this issue Nov 24, 2021 · 2 comments
Closed
Assignees

Comments

@frankli998
Copy link

Please describe your suggestion, and the problem it'd solve.
Currently, the "return to library" button always return to homepage of LRR, but it's not intuitive enough. For example, I entered reading mode from page 10 of my whole collection, but when I returned to library, I ended up page 1. Same with category. Suppose I am viewing some category, I would like to return to that category after finish reading instead of just returning to homepage.

That is to say, return to library is better return to where I entered reading mode instead of directly go to homepage.

Additional context
Add any other context or screenshots about the feature request here.

@Difegue
Copy link
Owner

Difegue commented Nov 24, 2021

There have been a few requests for this; The way I'd implement it would be to save last search/sort in localStorage so that loading the index will automatically do the last search if no other URL parameters are specified.

@Difegue Difegue added this to the 2021 User Survey Requests milestone Nov 24, 2021
@Difegue Difegue self-assigned this Nov 26, 2021
Difegue added a commit that referenced this issue Nov 29, 2021
@Difegue
Copy link
Owner

Difegue commented Nov 29, 2021

Left the localStorage idea on the table since it was much more annoying to implement and went for a referrer-based solution, which pulls the query parameters off the URL that led to the reader, and slaps them on the "return to index" button.

This is a bit of a naive solution, but the server will just ignore query parameters it doesn't know, so I don't think it'll bring any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants