Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EH: Query-parameter "p" included in source-tag #645

Closed
Pheromir opened this issue Jun 19, 2022 · 1 comment
Closed

EH: Query-parameter "p" included in source-tag #645

Pheromir opened this issue Jun 19, 2022 · 1 comment

Comments

@Pheromir
Copy link
Contributor

LRR Version and OS
Latest LRR Nightly on Docker

Bug Details
If you download a gallery from EH using the URL, the complete URL is set as a source-tag, including the query parameter "p" ([...]/g/xxxxxxx/xxxxxxx/?p=x) if you're on another page of the gallery, "?p=1" for example if you're on the second image page of the gallery.
(I hope you understand what I mean)

As the query parameter is included in the source-tag, the tsukihi extension will only show the gallery as already downloaded if you're on the exact same page. If you downloaded the gallery while being on page two, the extension won't recognize it if you're on page 1.

Matching Logs
none

Screenshots
grafik

Difegue added a commit that referenced this issue Jun 24, 2022
@Difegue
Copy link
Owner

Difegue commented Jun 24, 2022

The URL cleanup routine that creates source tags now removes query parameters by default.
This will theoretically break source URLs for downloads that come from services where the only unique part is in query parameters (stuff like http://download.com/file?id=1234), but we don't have any of those right now so it's fine™️ ¯\_(ツ)_/¯

@Difegue Difegue closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants