Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EHentai Plugin] Not use artist tag by default #798

Closed
chu-shen opened this issue May 1, 2023 · 2 comments
Closed

[EHentai Plugin] Not use artist tag by default #798

chu-shen opened this issue May 1, 2023 · 2 comments

Comments

@chu-shen
Copy link

chu-shen commented May 1, 2023

If the artist's name is not in English, the text search will return 'No matching EH Gallery Found!'

This code can be found at

my $has_artist = 0;
# Add artist tag from the OG tags if it exists
if ( $tags =~ /.*artist:\s?([^,]*),*.*/gi ) {
$URL = $URL . "+" . uri_escape_utf8("artist:$1");
$has_artist = 1;
}

For example:

  • artist:kokutou nikke ✅
  • artist:黒糖ニッケ ❎

It is recommended to either add a switch for this feature or remove it altogether.

@Jesan71
Copy link

Jesan71 commented May 2, 2023

Finally know why the plugin always find no match. I use Filename Parsing first and Jp artist's name tag was added.

@Difegue
Copy link
Owner

Difegue commented May 4, 2023

Thanks for that report. It's true that EH doesn't support non-ascii characters in their tags, so it doesn't make much sense to try and slam those in the URL searches...

I've pushed a change to filter non-english tags out of searches. Thanks again!

@Difegue Difegue closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants