Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New toast and notification dependcies #620

Merged
merged 18 commits into from
May 3, 2022
Merged

New toast and notification dependcies #620

merged 18 commits into from
May 3, 2022

Conversation

xiazeyu
Copy link
Contributor

@xiazeyu xiazeyu commented May 1, 2022 •
edited
Loading

Great thanks to @EYHN for CSS styling guide.

Difegue
Difegue reviewed May 2, 2022
View reviewed changes
tools/install.pl Show resolved Hide resolved
public/js/server.js Show resolved Hide resolved
public/js/init_toast.js Outdated Show resolved Hide resolved
public/js/init_toast.js Outdated Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
@xiazeyu xiazeyu marked this pull request as ready for review May 2, 2022 10:38
Difegue
Difegue reviewed May 2, 2022
View reviewed changes
public/themes/g.css Outdated Show resolved Hide resolved
public/themes/modern_clear.css Outdated Show resolved Hide resolved
public/themes/modern_red.css Outdated Show resolved Hide resolved
public/themes/modern.css Outdated Show resolved Hide resolved
public/js/server.js Show resolved Hide resolved
Difegue
Difegue requested changes May 2, 2022
View reviewed changes
Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new styling looks good! Good job on preserving the clickable links and such.
Toastify + sweetalert is a nice combo that sets a good base for further modernizations of the app, so pretty stoked to get this merged. 👍🔥

@xiazeyu xiazeyu requested a review from Difegue May 2, 2022 17:07
@Difegue Difegue merged commit ebde04a into Difegue:dev May 3, 2022
@xiazeyu xiazeyu deleted the new-toast branch May 3, 2022 12:05
xiazeyu
xiazeyu commented May 4, 2022
View reviewed changes
public/js/server.js
heading: successMessage,
icon: "success",
hideAfter: 70000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Difegue Sorry but typo here.
It should be hideAfter: 7000,

@xiazeyu xiazeyu mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Difegue Difegue Difegue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiazeyu @Difegue