Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nHentai-Plugin to bypass CF JS-Challenge #633

Merged
merged 2 commits into from
May 26, 2022
Merged

Add nHentai-Plugin to bypass CF JS-Challenge #633

merged 2 commits into from
May 26, 2022

Conversation

Pheromir
Copy link
Contributor

Added a new plugin to pass cookies and a useragent to LRR to bypass the Cloudflare JavaScript-Challenge.
I specifially named it like that (instead of "nHentai Login" or something like that) so it doesn't get confused with an actual login to the website.

The login plugin is based on the login-example from the documentation and your ehlogin.
for the Metadata-Plugin I changed the author to "Difegue and others" as it is the same way in the E-Hentai Metadata Plugin as an example.

I hope everything's fine, but you might check twice to be sure, as it's the first time I used pearl.

Tested one archive by providing a URL (see screenshot) and one archive by uploading it with the gID in the name ("{id} name") - both worked.

firefox_2022-05-25-18-45-10

@Pheromir
Copy link
Contributor Author

(this should close #631)

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for having taken the time to research this; Code-wise everything looks fine, I only have a few nitpicks on wording for the plugin's user-facing instructions. ✌️

lib/LANraragi/Plugin/Login/nHentai.pm Outdated Show resolved Hide resolved
lib/LANraragi/Plugin/Login/nHentai.pm Outdated Show resolved Hide resolved
lib/LANraragi/Plugin/Login/nHentai.pm Outdated Show resolved Hide resolved
Co-authored-by: Difegue <sugoi@cock.li>
@Pheromir
Copy link
Contributor Author

Code-wise everything looks fine

Nice.

I only have a few nitpicks on wording for the plugin's user-facing instructions. ✌️

I kinda thought that would happen, I wasn't sure if the description would have been too long or something like that (except for the of/for mistake). I applied your suggestions. (Writing that because I don't know if you've gotten any notification about it, as the webhook in the discord channel didn't post anything, lol)

@Pheromir Pheromir requested a review from Difegue May 26, 2022 10:41
Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the delay and thanks again.

@Difegue Difegue merged commit 38989bb into Difegue:dev May 26, 2022
@Andor233
Copy link

Thanks! It works fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants